test: Add stubs for SSO login to IAM domain testing#8652
Draft
ziwikiwi wants to merge 1 commit intoaws:masterfrom
Draft
test: Add stubs for SSO login to IAM domain testing#8652ziwikiwi wants to merge 1 commit intoaws:masterfrom
ziwikiwi wants to merge 1 commit intoaws:masterfrom
Conversation
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
** TEST PR DO NOT MERGE **
Tested scoped-down admin credentials to see if we can get to use project credentials for IAM domain activities for an SSO user. There are a couple of places where we need to switch to use the domain type (IAM) instead of the login type, which is set to an SSO user.
Tested by changing the admin project role to a role with just the scoped-down admin credentials, and changing SSORedeemToken to only vend that role's credentials.
Solution
For the credential routing fixes below
Credential Routing Fixes (flagged with smusIamDomainSsoTest)
These places were using DER/domain credentials but need project credentials for IAM domain SSO login. They may need to be flagged for this to work.
Dev Settings Added (settings.ts)
Three new aws.dev.* settings:
feature/xbranches will not be squash-merged at release time.