adds builds for opentnpd and dhcpcd for linuxkit images #3883
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/L
jaxesn
force-pushed
the
jgw/linuxkit-ntpd-dhcp
branch
3 times, most recently
from
8d0ecb3 to
e1b6a39
Compare
jaxesn
force-pushed
the
jgw/linuxkit-ntpd-dhcp
branch
from
e1b6a39 to
7da66e4
Compare
| @@ -0,0 +1,6 @@ | |||
| DHCPCD: | |||
There was a problem hiding this comment.
This is kind of a new pattern, we may want to break these builds out later on, for now we are only going to use them here to produce images we only use during hook build time. I did model this a bit off how we do the builder-base versions.yaml. I was thinking this would be easy to add the upgrade script to check for new versions and update.
|
/test all |
| dhcpcd/images/% openntpd/images/%: BASE_IMAGE_NAME=eks-distro-minimal-base-glibc | ||
|
|
||
| $(call IMAGE_TARGETS_FOR_NAME,openntpd): openntpd-useradd/images/export | ||
| openntpd-useradd/images/export: IMAGE_USERADD_USER_NAME=_ntp |
There was a problem hiding this comment.
Where is this username coming from? Couldn't find it in the upstream Linuxkit openntpd Dockerfile.
| $(OUTPUT_BIN_DIR)/%/dhcpcd/usr/sbin/dhcpcd: VERSION=$(shell yq '.DHCPCD.version' dependencies.yaml ) | ||
| $(OUTPUT_BIN_DIR)/%/dhcpcd/usr/sbin/dhcpcd: SHA256SUM=$(shell yq '.DHCPCD.sha256sum' dependencies.yaml ) | ||
| $(OUTPUT_BIN_DIR)/%/dhcpcd/usr/sbin/dhcpcd: $(GIT_PATCH_TARGET) | $$(call ENABLE_DOCKER_PLATFORM,$$(PLATFORM)) | ||
| mkdir -p $(OUTPUT_DIR)/dhcpcd; \ |
There was a problem hiding this comment.
Maybe we could move this and the one below for openntpd into a common script or Macro
Issue #, if available:
Description of changes:
This adds openntpd and dhcpcd builds to linuxkit. Neither of these exists in al2/al23 so building from the source. The new base images for these are al2 based.
The openntpd build is not built with
libtlsso the cert validation constraint would not be supported, but based on the ntp config we are using I do not believe this is needed:I went through the dhcpcd hooks and the additional mtu script linuxkit provides to make sure I included all the utils it needs (cat/rm/set/etc). This is something we have to pay attention to when updating, I added a note to the hook readme.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.