Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves hook build #4019

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improves hook build #4019

wants to merge 1 commit into from

Conversation

jaxesn
Copy link
Member

@jaxesn jaxesn commented Nov 7, 2024

Issue #, if available:

Description of changes:

This improves the building of hook locally. Hook requires a number of images from other projects. Currently this requires building them all locally and pushing to your regi. Also because the linuxkit part is run within a docker container pulling from local/private regi was not possible.

This introduces a new env var to set the image repo for these images so you can pull these from the eksa build account, assuming you have ecr creds. Images are also pulled on the host before calling linuxkit in the container to allow for "any" regi to work since we do not have to worry about auth.

Updates the helper that creates the buildkitd container to use buildx, since we have been using that for a while by default, and also sets network=host to allow for that container to push to a locally running regi.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jaxesn. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2024
@jaxesn
Copy link
Member Author

jaxesn commented Nov 7, 2024

/hold

@jaxesn jaxesn force-pushed the jgw/improve-hook-build branch from 0520840 to 224a30c Compare November 7, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants