chore: end-2-end test for covariant overrides in classes #4925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/chore/class-covariant-overrides-tests
branch
from
341e875 to
fc8c4ed
Compare
mrgrain
force-pushed
the
mrgrain/chore/class-covariant-overrides-tests
branch
2 times, most recently
from
f9f27f7 to
8b209be
Compare
mrgrain
force-pushed
the
mrgrain/chore/class-covariant-overrides-tests
branch
from
d9f8334 to
e9d2913
Compare
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2025
) This adds support for the new `class-covariant-overrides` feature into `@jsii/spec`. `class-covariant-overrides` relaxes the existing restriction on covariant overrides [^1]. With the feature it is now allowed to override the `type of readonly class properties` and the `return type of class methods` when extending other classes, as long as the changes are covariant [^2] [^3] to the superclass. Importantly, covariant overrides are still not allowed when implementing interfaces. Compilers that are producing assemblies with covariant class overrides MUST include `class-covariant-overrides` in the `usedFeatures` set. This feature does not require any changes to the kernels, runtimes or packmak. All generated code already is already correct when given an appropriate assembly. We can now add support for this feature due to the upgrade to `net6.0` [^4] which was the only thing blocking it. Proof all of this is working together: #4925 [^1]: https://aws.github.io/jsii/user-guides/lib-author/typescript-restrictions/#covariant-overrides-parameter-list-changes [^2]: https://en.wikipedia.org/wiki/Covariance_and_contravariance_(computer_science) [^3]: As of today this feature strictly applies to class and interface types, event though some built-in types like lists might also be technically covariant. [^4]: #4916 --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
rix0rrr
reviewed
Sep 15, 2025
|
Here is what I was referring to: #4929 |
I'll wait for you PRs to be merged to avoid duplication. 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing PR for end-2-end tests for #4924
This uses a jsii-compiler pre-release to demonstrate functionality.
Order of publishing will be:
class-covariant-overrides#4924By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.