fix: move pinContextHint to config texts #389
Merged
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogusata
approved these changes
Jul 8, 2025
dogusata
previously approved these changes
Jul 8, 2025
|
Only thing, it might be better to use the code for the OPTION character, in case there will be some different type of encodings. |
dogusata
approved these changes
Jul 8, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Pin context with ⌥ Enterhint text was hardcoded which violates the guidelines of having all strings in config texts. The consumer needs to be able to override this string since Windows machines useAlt EnterSolution
Move hardcoded pin context hint string to config texts so consumers can override string.
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.