fix: separate text for prompt-input-stop-button label and tooltip #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dungdong-aws
changed the title
yueny2020
reviewed
Jul 10, 2025
ashishrp-aws
previously approved these changes
Jul 11, 2025
dungdong-aws
dismissed stale reviews from ashishrp-aws and laileni-aws
via
22bc505
dungdong-aws
force-pushed
the
fix/prompt-input-stop-button
branch
from
22bc505 to
430d787
Compare
laileni-aws
previously approved these changes
Jul 13, 2025
avi-alpert
approved these changes
Jul 14, 2025
This was referenced Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, we show a
tooltipfor theStopbutton in prompt-input section by definingstopGeneratingtext inconfig. That value is also used bylabelof the button. This limits our use case because if we have a keyboard shortcut, that we want to show in the tooltip, this does not work. See the image below:Solution
Separate text for tooltip and description by adding
stopGeneratingTooltiptoconfig. I don't want it to break other IDEs so I make that field optional. But in the future, we can make it required.VSC Screenshot:
Tests
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.