address pr feedback

- remove param information from internal comments
aws · Jan 16, 2024 · 33098d0 · 33098d0
1 parent 53e008e
commit 33098d0
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/crypto/s2n_openssl_x509.h b/crypto/s2n_openssl_x509.h
@@ -34,10 +34,6 @@ S2N_CLEANUP_RESULT s2n_openssl_asn1_time_free_pointer(ASN1_GENERALIZEDTIME **tim
  * This function is used to convert an s2n_blob into an openssl X509 cert. It
  * will additionally ensure that there are 3 or fewer trailing bytes in
  * `asn1der`.
- *
- * @param asn1der the s2n_blob containing the der-encoded bytes of the x509
- * certificate.
- * @param cert_out the pointer where the parsed `X509*` will be stored.
  */
 S2N_RESULT s2n_openssl_x509_parse(struct s2n_blob *asn1der, X509 **cert_out);
 
@@ -46,9 +42,5 @@ S2N_RESULT s2n_openssl_x509_parse(struct s2n_blob *asn1der, X509 **cert_out);
  * Unlike `s2n_openssl_x509_parse` no additional validation is done. This
  * function should only be used in places where it is necessary to maintain
  * compatability with previous permissive parsing behavior.
- *
- * @param asn1der the s2n_blob containing the der-encoded bytes of the x509
- * certificate.
- * @param cert_out the pointer where the parsed `X509*` will be stored.
  */
 S2N_RESULT s2n_openssl_x509_parse_without_length_validation(struct s2n_blob *asn1der, X509 **cert_out);
diff --git a/tls/s2n_x509_validator.c b/tls/s2n_x509_validator.c
@@ -704,7 +704,6 @@ S2N_RESULT s2n_x509_validator_validate_cert_chain(struct s2n_x509_validator *val
         RESULT_ENSURE(info.accepted, S2N_ERR_CERT_REJECTED);
     }
 
-
     /* retrieve information from leaf cert */
     RESULT_ENSURE_GT(sk_X509_num(validator->cert_chain_from_wire), 0);
     X509 *leaf_cert = sk_X509_value(validator->cert_chain_from_wire, 0);