-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev shell tests with pytest #4062
Draft
dougch
wants to merge
8
commits into
aws:main
Choose a base branch
from
dougch:devShell_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Jun 23, 2023
goatgoose
approved these changes
Jun 27, 2023
lrstewart
reviewed
Jul 11, 2023
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
possible solution to #4056
Description of changes:
Wait for sslyze resolution in #4373
Move the bash checks for devShell utilities into pytest, and run it at the start of every
nix develop
run.Call-outs:
For tests that are platform specific, this sets up a pytest marker to skip if we're running on an unsupported platform.
Note: the pytest marker only applies to this nix test, but could be added to integrationv2 in a future pr.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally. CI nix jobs will run this update as well.
on x86:
on aarch64, only the last two lines differ:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.