bug: Fixes mdbook action #4345
Merged
bug: Fixes mdbook action #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Jan 8, 2024
dougch
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
My previous mdbook PR didn't actually deploy the mdbook because I messed up the arguments for the github action 😮💨 . Here I am fixing this action and including a doc change in this PR so that the mdbook actually deploys (I'm not sure the action will trigger if the docs don't change, so I included a change that I've been meaning to make just to be sure.)
Testing:
I tested this on my fork and the action does actually complete this time. Although of course the push to S3 fails because my repo doesn't have credentials.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.