test(s2n-tls-hyper): Add localhost http tests #4838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
force-pushed
the
hyper-tests
branch
5 times, most recently
from
03554a0
to
5015598
Compare
goatgoose
force-pushed
the
hyper-tests
branch
4 times, most recently
from
efb941b
to
5a37f10
Compare
This was referenced Oct 22, 2024
goatgoose
force-pushed
the
hyper-tests
branch
from
5a37f10
to
2bf3897
Compare
goatgoose
force-pushed
the
hyper-tests
branch
from
2bf3897
to
68f6c9e
Compare
camshaft
reviewed
Oct 22, 2024
camshaft
approved these changes
Oct 25, 2024
jmayclin
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4631
Description of changes:
This PR adds a way to test s2n-tls-hyper over localhost by using the hyper server to echo HTTP requests back to the s2n-tls hyper client. A few tests were added which make use of the echo framework.
Call-outs:
Now that s2n-tls-hyper is tested locally, the web_client test was removed to reduce flakiness caused by relying on an external endpoint.
Testing:
All tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.