Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integv2 reduction #4842

Closed
wants to merge 2 commits into from
Closed

Integv2 reduction #4842

wants to merge 2 commits into from

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Oct 11, 2024

Description of changes:

The Integration tests in nix currently duplicate what's in the current integrationv2 tests, remove the duplicates.

Call-outs:

Doing this in chunks, this is PR one of 2-3.

Arguing we are testing with aws-lc, we should not bother with a ~2 year old pinned version of boringssl.

Diff between original an final:

--- a/codebuild/spec/buildspec_integv2batch2.yml
+++ b/codebuild/spec/buildspec_integv2batch2.yml
@@ -20,17 +20,14 @@ batch:
             - awslc-fips-2022_gcc6
             - libressl_gcc6
             - libressl_gcc9
-            - boringssl
             - openssl-1.0.2
             - openssl-1.0.2-fips
             - openssl-1.1.1_gcc4-8
             - openssl-1.1.1_gcc6
             - openssl-1.1.1_gcc6_softcrypto
             - openssl-1.1.1_gcc9
-          INTEGV2_TEST: 
+          INTEGV2_TEST:
             - "test_happy_path"
-            - "test_cross_compatibility test_client_authentication"
-            - "test_early_data test_sslyze test_well_known_endpoints test_hello_retry_requests test_sni_match test_pq_handshake test_fragmentation test_key_update"
-            - "test_session_resumption test_ocsp test_renegotiate test_renegotiate_apache"
-            - "test_dynamic_record_sizes test_npn test_signature_algorithms"
-            - "test_version_negotiation test_external_psk test_buffered_send"
+            - "test_sslyze test_fragmentation test_key_update"
+            - "test_session_resumption test_dynamic_record_sizes"
+            - "test_version_negotiation test_external_psk"

Testing:

How is this change tested: locally, ad-hoc

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Oct 11, 2024
@dougch dougch closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant