Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix incorrect README references #4863

Merged
merged 6 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ s2n_config_set_cipher_preferences(config, "20150306")

Internally s2n-tls takes a systematic approach to data protection and includes several mechanisms designed to improve safety.

##### Small and auditable code base
Ignoring tests, blank lines and comments, s2n-tls is about 6,000 lines of code. s2n's code is also structured and written with a focus on reviewability. All s2n-tls code is subject to code review, and we plan to complete security evaluations of s2n-tls on an annual basis.
##### Auditable code base
s2n-tls's code is structured and written with a focus on reviewability. All s2n-tls code is subject to code review, and we plan to complete security evaluations of s2n-tls on an annual basis.

To date there have been two external code-level reviews of s2n-tls, including one by a commercial security vendor. s2n-tls has also been shared with some trusted members of the broader cryptography, security, and Open Source communities. Any issues discovered are always recorded in the s2n-tls issue tracker.

Expand All @@ -148,7 +148,7 @@ s2n-tls encrypts or erases plaintext data as quickly as possible. For example, d
s2n-tls uses operating system features to protect data from being swapped to disk or appearing in core dumps.

##### Minimalist feature adoption
s2n-tls avoids implementing rarely used options and extensions, as well as features with a history of triggering protocol-level vulnerabilities. For example there is no support for session renegotiation or DTLS.
s2n-tls avoids implementing rarely used options and extensions, as well as features with a history of triggering protocol-level vulnerabilities. For example, there is no support for DTLS.

##### Compartmentalized random number generation
The security of TLS and its associated encryption algorithms depends upon secure random number generation. s2n-tls provides every thread with two separate random number generators. One for "public" randomly generated data that may appear in the clear, and one for "private" data that should remain secret. This approach lessens the risk of potential predictability weaknesses in random number generation algorithms from leaking information across contexts.
Expand Down
8 changes: 6 additions & 2 deletions crypto/s2n_sequence.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,13 @@ int s2n_increment_sequence_number(struct s2n_blob *sequence_number)
break;
}

/* RFC 5246 6.1: If a TLS implementation would need to wrap a sequence number, it must
* renegotiate instead. We don't support renegotiation. Caller needs to create a new session.
/* Renegotiation is an unstable feature currently used for delayed client auth. Instead of
* triggering renegotiation, throw an error.
* This condition is very unlikely. It requires 2^64 - 1 records to be sent.
lrstewart marked this conversation as resolved.
Show resolved Hide resolved
*
*= https://www.rfc-editor.org/rfc/rfc5246#section-6.1
*# If a TLS implementation would need to wrap a sequence number, it must
*# renegotiate instead.
*/
S2N_ERROR_IF(i == 0, S2N_ERR_RECORD_LIMIT);

Expand Down
3 changes: 1 addition & 2 deletions tls/s2n_connection.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ struct s2n_connection {
/* Connection can be used by a QUIC implementation */
unsigned quic_enabled : 1;

/* s2n does not support renegotiation.
* RFC5746 Section 4.3 suggests servers implement a minimal version of the
/* RFC5746 Section 4.3 suggests servers implement a minimal version of the
* renegotiation_info extension even if renegotiation is not supported.
* Some clients may fail the handshake if a corresponding renegotiation_info
* extension is not sent back by the server.
Expand Down
3 changes: 1 addition & 2 deletions tls/s2n_handshake_io.c
Original file line number Diff line number Diff line change
Expand Up @@ -1389,8 +1389,7 @@ static S2N_RESULT s2n_handshake_app_data_recv(struct s2n_connection *conn)
* types to be interleaved at the record layer. We may get an alert message
* during the handshake phase, or messages of types that we don't support (e.g.
* HEARTBEAT messages), or during renegotiations we may even get application
* data messages that need to be handled by the application. The latter is punted
* for now (s2n does not support renegotiations).
* data messages that need to be handled by the application.
*/
static int s2n_handshake_read_io(struct s2n_connection *conn)
{
Expand Down
Loading