fix(integV2): remove unused protocol in well-known-endpoints #4875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This test queries each endpoint more than necessary.
The current test runs once for each protocol/cipher tuple. But the protocol has little effect on the security policy selection, so there are lots of duplicate test runs.
s2n-tls/tests/integrationv2/providers.py
Lines 243 to 251 in 53691f9
E.g, all of the following tuples have the same exact configuration, because of the cipher preferences override on line 249.
So each endpoint was queried 5 * 6 = 30 times, even though most queries were duplicates. After this change, each endpoints will only be queried 6 times.
I think that is still excessive, but this PR keeps coverage strictly the same, and only removes duplicated queries.
Testing:
Existing CI should pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.