Skip to content

Fix ObjectVersion on SPC with no secrets #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix ObjectVersion on SPC with no secrets #530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5151790
fix ObjectVersion on SPC with no secrets
OS-marcoguilherme Oct 3, 2025
16bb931
Merge branch 'main' into fix/nil-objectversion-on-empty-objects
simonmarty Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func (s *CSIDriverProviderServer) Mount(ctx context.Context, req *v1alpha1.Mount
}

providerFactory := s.secretProviderFactory(awsConfigs, regions)
var fetchedSecrets []*provider.SecretValue
fetchedSecrets := []*provider.SecretValue{}
for sType := range descriptors { // Iterate over each secret type.
// Fetch all the secrets and update the curVerMap
provider := providerFactory.GetSecretProvider(sType)
Expand All @@ -187,7 +187,7 @@ func (s *CSIDriverProviderServer) Mount(ctx context.Context, req *v1alpha1.Mount
}

// Write out the secrets to the mount point after everything is fetched.
var files []*v1alpha1.File
files := []*v1alpha1.File{}
for _, secret := range fetchedSecrets {
file, err := s.writeFile(secret, secret.Descriptor.GetFilePermission())
if err != nil {
Expand All @@ -199,7 +199,7 @@ func (s *CSIDriverProviderServer) Mount(ctx context.Context, req *v1alpha1.Mount
}

// Build the version response from the current version map and return it.
var ov []*v1alpha1.ObjectVersion
ov := []*v1alpha1.ObjectVersion{}
for id := range curVerMap {
ov = append(ov, curVerMap[id])
}
Expand Down