-
Notifications
You must be signed in to change notification settings - Fork 154
Remove unneeded helpers, use kubectl waiters, set bash strict mode #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 60.10% 60.10%
=======================================
Files 11 11
Lines 762 762
=======================================
Hits 458 458
Misses 287 287
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| load helpers | ||
|
|
||
| WAIT_TIME=120 | ||
| SLEEP_TIME=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add these variables back in? I think these are needed by wait_for_process helper function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this made me realize I can't strip out wait_for_process because it's being used by the aws.bats file used by the upstream driver end to end tests, putting those back in.
The two env vars can be stripped out though, the usage of these helpers has been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The driver doesn't actually use our aws.bats file, theirs diverged a while ago. I removed aws.bats and the rest of the old testing setup in #541
Issue #, if available:
Description of changes:
wait_for_processisn't needed as far as I can tell. We can do all the waiting we need usingkubectl'swaitcommand.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.