Skip to content

Conversation

@simonmarty
Copy link
Contributor

Issue #, if available:

Description of changes:

  • wait_for_process isn't needed as far as I can tell. We can do all the waiting we need using kubectl's wait command.
  • Set bash strict mode to exit non-zero on subcommand failure. This ensures we exit non-zero on a failing bats test.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@simonmarty simonmarty requested a review from a team as a code owner November 17, 2025 19:46
@simonmarty simonmarty added the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.10%. Comparing base (6dbe3b9) to head (65203a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   60.10%   60.10%           
=======================================
  Files          11       11           
  Lines         762      762           
=======================================
  Hits          458      458           
  Misses        287      287           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Nov 17, 2025
@simonmarty simonmarty added the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Nov 17, 2025
load helpers

WAIT_TIME=120
SLEEP_TIME=1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add these variables back in? I think these are needed by wait_for_process helper function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this made me realize I can't strip out wait_for_process because it's being used by the aws.bats file used by the upstream driver end to end tests, putting those back in.

The two env vars can be stripped out though, the usage of these helpers has been removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The driver doesn't actually use our aws.bats file, theirs diverged a while ago. I removed aws.bats and the rest of the old testing setup in #541

@github-actions github-actions bot removed the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Nov 18, 2025
@reyhankoyun reyhankoyun added the safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on. label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe-to-test Pull Request has been manually reviewed and deemed to be safe to run integration tests on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants