Bugfix: Fixes issue where headers were treated as case sensitive after deserialization.#216
Closed
eirikjak wants to merge 1 commit intoaws:masterfrom
Closed
Bugfix: Fixes issue where headers were treated as case sensitive after deserialization.#216eirikjak wants to merge 1 commit intoaws:masterfrom
eirikjak wants to merge 1 commit intoaws:masterfrom
Conversation
Contributor
|
Thank you! I've merged the changes in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug seems to have been introduced when the MultiValuedTreeMap was added to support multi valued headers.
The bug:
When the MultiValuedTreeMap used for the multiValueHeaders property on AwsProxyRequest is deserialized the default constructor is used. The result is that the headers keys are treated as case sensitive because the String.CASE_INSENSITIVE_ORDER comparator is not used for the underlying TreeMap.