Java:Transcribe, medical streaming #7044
Open
+233
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
Java-v2
Laren-AWS
requested changes
Nov 6, 2024
| @@ -262,7 +262,20 @@ transcribe_StartStreamTranscriptionAsync: | |||
| snippet_tags: | |||
| - transcribe.cpp.stream_transcription_async.code | |||
| services: | |||
| transcribe: {StartStreamTranscriptionAsync} | |||
| transcribe: {StartStreamTranscription} | |||
| transcribe_StartMedicalStreamTranscription: | |||
There was a problem hiding this comment.
It looks like both of these APIs are part of a separate service client transcribe_streaming, so you'll need to create an entry for that in services.yaml and reference it here for the API ref links to work correctly.
| @@ -0,0 +1,206 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Tests? At least simple integration tests like other Java examples.
|
|
||
| if (!AudioSystem.isLineSupported(info)) { | ||
| System.out.println("Line not supported"); | ||
| System.exit(0); |
There was a problem hiding this comment.
This strikes me as an unusual way to handle this. Why not throw an exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a transcribe medical streaming example.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.