chore: split dynamodb-mapper-codegen into two modules #1414
Conversation
|
A new generated diff is ready to view.
|
gradle.properties
Outdated
|
|
||
| # https://github.com/google/ksp/blob/main/docs/ksp2.md | ||
| ksp.useKSP2=true |
There was a problem hiding this comment.
Question: Is there anything we should be concerned about with V2? Since it's in beta
There was a problem hiding this comment.
Nothing major, they have a list of known issues and other migration tips and none of them applied to us. We will need to move to KSP2 once the next version of Kotlin is released:
KSP1 will not support Kotlin 2.1. Please plan transitioning from KSP1 to KSP2 during Kotlin 2.0.
gradle.properties
Outdated
|
|
||
| # https://github.com/google/ksp/blob/main/docs/ksp2.md | ||
| ksp.useKSP2=true |
There was a problem hiding this comment.
Nit: Please end file with a newline
| plugins { | ||
| alias(libs.plugins.kotlin.jvm) | ||
| `maven-publish` | ||
| } |
There was a problem hiding this comment.
Question: Is it necessary to publish the ops codegen module? I thought we only had a build-time use case for it.
There was a problem hiding this comment.
I think you're right, I'll remove this publication
|
|
A new generated diff is ready to view.
|
…lin (#1451) * initial poc commit of DynamoDB Mapper (#1232) * add support for Mapper initialization (#1237) * implement mapper pipeline (#1266) * initial implementation of codegen for low-level operations/types (#1357) * initial implementation of secondary index support (#1375) * Create new codegen module and refactor annotation processor to use it (#1382) * feat: add Schema generator Gradle plugin (#1385) * Fix plugin test package * add attribute converters for "standard" values (#1381) * fix: schema generator plugin test module (#1394) * feat: annotation processor codegen configuration (#1392) * feat: add `@DynamoDbIgnore` annotation (#1402) * DDB Mapper filter expressions (runtime components) (#1401) * feat: basic annotation processing (#1399) * add DSL overloads, paginators, and better builder integration for DDB Mapper ops codegen (#1409) * chore: split dynamodb-mapper-codegen into two modules (#1414) * emit DDB_MAPPER business metric (#1426) * feat: setup DynamoDbMapper publication (#1419) * DDB Mapper filter expressions (codegen components) (#1424) * correct docs * mark every HLL/DDBM API experimental (#1428) * fix accidental inclusion of expression attribute members in high-level DynamoDB Mapper requests (#1432) * Upgrade to latest build plugin version * fix: various issues found during testing (#1450) * chore: update Athena changelog notes for 1.3.57 (2024-10-18) release (#1449) * feat: update AWS API models * feat: update AWS service endpoints metadata * chore: release 1.3.60 * chore: bump snapshot version to 1.3.61-SNAPSHOT * feat: initial release of Developer Preview of DynamoDB Mapper for Kotlin * Fix Kotlin gradle-plugin version * fix: ddb mapper tests (#1453) * Bump build plugin version --------- Co-authored-by: Matas <[email protected]> Co-authored-by: aws-sdk-kotlin-ci <[email protected]>
This PR was intended to fix an outstanding FIXME in
Annotations.ktaround switching converterName from a string toKClass<ItemConverter<*>>, but we are blocked by a bug in KSP: google/ksp#1129Part of addressing that FIXME required splitting dynamodb-mapper-codegen into two modules (ops and schema), which is what I've published here.
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.