Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 307 redirect when refreshing tokens in background to keep HTTP method #83

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swantzter
Copy link

Issue # (if available): fixes #82

Description of changes:

When redirecting to cognito, or we handle a request that's been redirected from cognito we likely want to try GET on the target since a) cognito expects it or b) if we've taken a detour to cognito the original method is lost anyway.
However, when we've refreshed tokens in the background and use a redirect response to the same url that was requested to set cookies we want the original request to be retried with the same method as it was originally made with, this way background POST/PUT/etc requests from web apps will not fail on the first try where tokens are refreshed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using HTTP 307 instead of HTP 302
1 participant