Make observed_value_field optional in TFTInstanceSplitter #3259
+9
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulfatir
changed the title
abdulfatir
changed the title
|
@shchur @lostella there's an issue with |
shchur
approved these changes
Jun 27, 2025
| @@ -1 +1,4 @@ | |||
| # scipy cap can be removed once this is resolved: https://github.com/statsmodels/statsmodels/issues/9584 | |||
| scipy<1.16.0; python_version > "3.7.0" | |||
There was a problem hiding this comment.
The version cap looks reasonable to me
| @@ -1 +1,4 @@ | |||
| # scipy cap can be removed once this is resolved: https://github.com/statsmodels/statsmodels/issues/9584 | |||
| scipy<1.16.0; python_version > "3.7.0" | |||
| scipy~=1.7.3; python_version <= "3.7.0" | |||
There was a problem hiding this comment.
I would just skip this completely: Python 3.8 is already EOL for a while so we don't need to worry about it
There was a problem hiding this comment.
I guess it's just a bit redundant, but since there may be EOL versions of Python running and doing stuff 🤖 doesn't hurt to leave it like this
lostella
approved these changes
Jun 27, 2025
lostella
added
bug fix
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Jun 27, 2025
*Issue #, if available:* N/A *Description of changes:* Previously, `TFTInstanceSplitter` assumed that the `observed_value_field` is always present in the entry. This PR fixes that. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Merged
lostella
added a commit
that referenced
this pull request
Jun 27, 2025
*Description of changes:* backport changes - #3259 - #3261 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup --------- Co-authored-by: Abdul Fatir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Previously,
TFTInstanceSplitterassumed that theobserved_value_fieldis always present in the entry. This PR fixes that.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup