generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 385
feat: Modular crypto #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
richarddavison
wants to merge
28
commits into
main
Choose a base branch
from
feat/modular-crypto
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Modular crypto #1292
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c54bb81
WIP
richarddavison 95c613f
Refactor crypto and HTTP modules to support multiple TLS backends
richarddavison c29dd0e
CI
richarddavison d94eee3
Allow all features
richarddavison 00ae1b4
Fix fixtures
richarddavison a642718
pkg-config
richarddavison 18d810b
Vendored openssl
richarddavison 0b44c08
Fix
richarddavison dd7330a
Cleanup features
richarddavison 241e108
Tweak features
richarddavison 9c8f534
Do not use macos-14
richarddavison 43e4e58
Adjust features
richarddavison cb01384
Fix flags
richarddavison a59d2ab
Cleanup CI
richarddavison 7a3b6fa
Cleanups
richarddavison 0cdb19c
Fix check
richarddavison 5aa5473
Features
richarddavison 1246c11
Allow deadcode for providers with missing algos
richarddavison 7656725
AES CPU feature detection
richarddavison 003563f
Format
richarddavison 476ace9
Clippy
richarddavison 5eef3b6
Disable test
richarddavison db9db46
Disable some tests
richarddavison 1602691
Disable tests
richarddavison ce0d72a
Gates
richarddavison 80850f5
Ignore if kill fails due to process already killed
richarddavison 322f76d
Merge branch 'main' into feat/modular-crypto
richarddavison b5cf8f1
Fix CI
richarddavison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,13 +29,68 @@ jobs: | |
| for i in {1..5}; do | ||
| echo "console.log(123);" > "bundle/js/test$i.js" | ||
| done | ||
| cargo clippy --all-targets --all-features -- -D warnings | ||
| cargo clippy --all-targets --features "lambda,macro,no-sdk,uncompressed,crypto-rust,tls-ring,openssl-vendored" -- -D warnings | ||
|
|
||
| build: | ||
| needs: | ||
| - check | ||
| strategy: | ||
| fail-fast: ${{ startsWith(github.ref, 'refs/tags/') }} | ||
| matrix: | ||
| os: | ||
| - windows-latest | ||
| - ubuntu-latest | ||
| - ubuntu-24.04-arm | ||
| - macos-latest | ||
| crypto: | ||
| - name: default | ||
| features: "" | ||
| limited_crypto: false | ||
| - name: crypto-rust+tls-ring | ||
| features: "--no-default-features --features crypto-rust,tls-ring,macro" | ||
| limited_crypto: false | ||
| - name: crypto-rust+tls-aws-lc | ||
| features: "--no-default-features --features crypto-rust,tls-aws-lc,macro" | ||
| limited_crypto: false | ||
| - name: crypto-ring+tls-ring | ||
| features: "--no-default-features --features crypto-ring,tls-ring,macro" | ||
| limited_crypto: true | ||
| - name: crypto-ring-rust+tls-ring | ||
| features: "--no-default-features --features crypto-ring-rust,tls-ring,macro" | ||
| limited_crypto: false | ||
| - name: crypto-graviola+tls-graviola | ||
| features: "--no-default-features --features crypto-graviola,tls-graviola,macro" | ||
| limited_crypto: true | ||
| - name: crypto-graviola-rust+tls-graviola | ||
| features: "--no-default-features --features crypto-graviola-rust,tls-graviola,macro" | ||
| limited_crypto: false | ||
| - name: crypto-openssl+tls-openssl | ||
| features: "--no-default-features --features crypto-openssl,tls-openssl,macro" | ||
| limited_crypto: false | ||
| exclude: | ||
| # OpenSSL requires native compilation - exclude from cross-compile targets | ||
| - os: ubuntu-latest | ||
| crypto: | ||
| name: crypto-openssl+tls-openssl | ||
| - os: ubuntu-24.04-arm | ||
| crypto: | ||
| name: crypto-openssl+tls-openssl | ||
| - os: windows-latest | ||
| crypto: | ||
| name: crypto-openssl+tls-openssl | ||
| # Graviola only supports aarch64 | ||
| - os: ubuntu-latest | ||
| crypto: | ||
| name: crypto-graviola+tls-graviola | ||
| - os: ubuntu-latest | ||
| crypto: | ||
| name: crypto-graviola-rust+tls-graviola | ||
| - os: windows-latest | ||
| crypto: | ||
| name: crypto-graviola+tls-graviola | ||
| - os: windows-latest | ||
| crypto: | ||
| name: crypto-graviola-rust+tls-graviola | ||
| include: | ||
| - os: windows-latest | ||
| platform: windows | ||
|
|
@@ -63,24 +118,27 @@ jobs: | |
| platform: ${{ matrix.platform }} | ||
| arch: ${{ matrix.arch }} | ||
| toolchain: ${{ matrix.toolchain }} | ||
| cargo_features: ${{ matrix.crypto.features }} | ||
| limited_crypto: ${{ matrix.crypto.limited_crypto }} | ||
|
|
||
| modules: | ||
| needs: | ||
| - check | ||
| strategy: | ||
| matrix: | ||
| os: | ||
| - ubuntu-latest | ||
| - macos-latest | ||
| - windows-latest | ||
| tls: | ||
| - tls-ring | ||
| - tls-aws-lc | ||
| - tls-graviola | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. missing tls-openssl |
||
| include: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unsure if you really need the include now? |
||
| - os: ubuntu-latest | ||
| platform: linux | ||
| arch: x86_64 | ||
| toolchain: stable | ||
| - os: ubuntu-24.04-arm | ||
| platform: linux | ||
| arch: aarch64 | ||
| toolchain: stable | ||
| - os: macos-latest | ||
| platform: darwin | ||
| arch: x86_64 | ||
| toolchain: stable | ||
| - os: macos-latest | ||
| platform: darwin | ||
| arch: aarch64 | ||
|
|
@@ -95,3 +153,4 @@ jobs: | |
| platform: ${{ matrix.platform }} | ||
| arch: ${{ matrix.arch }} | ||
| toolchain: ${{ matrix.toolchain }} | ||
| tls_feature: ${{ matrix.tls }} | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace that with