Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): implement of AesCbc*Variant and AesCtrVariant #750

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

nabetti1720
Copy link
Contributor

Description of changes

We created the following enum types and moved more of the implementation into them:

  • AesCbcEncVariant
  • AesCbcDecVariant
  • AesCtrVariant

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richarddavison richarddavison merged commit f3f4ecc into awslabs:main Dec 22, 2024
11 checks passed
@nabetti1720 nabetti1720 deleted the refactor/crypto branch December 22, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants