#1041 Enable receiving messages from different message groups i… #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the same Batch for FIFO queues Added a new SqsContainerOptions option : messageGrouping. True by default.
alexisgra
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
github-actions
bot
added
component: sqs
spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/listener/FifoSqsComponentFactory.java
Outdated
Show resolved
Hide resolved
spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/annotation/SqsListener.java
Outdated
Show resolved
Hide resolved
spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/config/SqsEndpoint.java
Outdated
Show resolved
Hide resolved
|
Thanks for the PR @alexisgra! Left a few comments for your consideration. |
…rategy Rename messageGrouping by batchGroupingStrategy and add an enum as suggested for better extensibility. Remove the message grouping option from SQSListener annotation
|
Thank you very much for the review @tomazfernandes ! |
spring-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/listener/SqsContainerOptions.java
Outdated
Show resolved
Hide resolved
...ng-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/listener/FifoBatchGroupingStrategy.java
Outdated
Show resolved
Hide resolved
...ng-cloud-aws-sqs/src/main/java/io/awspring/cloud/sqs/listener/FifoBatchGroupingStrategy.java
Show resolved
Hide resolved
added 2 commits
July 4, 2024 17:25
…operty to fifoBatchGroupingStrategy
|
Thanks for the review @tomazfernandes ! |
|
Thanks a lot for the PR @alexisgra! I did some polishing to speed up merging and opened a new PR: #1192, so I'll close this one. Looking forward to more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n the same Batch for FIFO queues
📢 Type of change
📜 Description
Added a new SqsContainerOptions option :
messageGrouping. True by default. When false, a newMessageSinkAdapteris used. This adapter does not have grouping function.I was wondering whether I should add the new option
messageGroupingin the@SqsListenerannotation or leave the configuration only in the factory.Although the option is only relevant for FIFO Queues with a listener in
batchmode, I've decided to put the option in@SqsListener, which will make it easier for library users to configure.I don't know if the name
messageGroupingis meaningful enough, I can change it if necessary.💡 Motivation and Context
Fix the issue #1041
💚 How did you test it?
I added a test in
SqsFifoIntegrationTests. In this test, I configure a new listener withmessageGroupingset tofalse. I send several messages from two different message groups.In the listener, I verify that the batch of messages received contains messages from different message groups. Then, I check that all messages from each group have been received.
📝 Checklist
🔮 Next steps