Fix MessagingMessageConverter to handle JSON string payload configured with the APPLICATION_JSON header (#1144) #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Application_JSON header
imsosleepy
requested review from
maciejwalkowiak,
MatejNedic and
tomazfernandes
as code owners
imsosleepy
changed the title
|
@imsosleepy, thanks for the PR! I did some polishing in a new PR for this one as well: #1195 Looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
When creating a raw JSON string type payload in the SQS Template, if the header is set to CONTENT_TYPE as APPLICATION_JSON and sent to SQS, the listener could not read the object in the same format.
💡 Motivation and Context
Implementation for issue #1144
💚 How did you test it?
📝 Checklist
🔮 Next steps