Skip to content
This repository was archived by the owner on Feb 4, 2025. It is now read-only.

Reproduce/lock down different dependencies #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reproduce/lock down different dependencies #2

wants to merge 2 commits into from

Conversation

@AndyOGo
Copy link
Contributor

@AndyOGo AndyOGo commented Oct 22, 2019 •
edited
Loading

Lock down @webcomponents/webcomponentsjs to version 2.2.10 from 2.3.0 and tests run again 🎉

npm run test

> [email protected] test /Users/axawinterthur/dev/jest-test-plib-v2
> node scripts/test.unit.js --env=jsdom

 PASS  src/App.test.js (22.16s)
  ● Console

    console.warn node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js:223
      Custom Elements: `Element#insertAdjacentElement` was not patched.

 PASS  src/components/AXAButton.test.js (23.511s)
  ● Console

    console.warn node_modules/@webcomponents/webcomponentsjs/webcomponents-bundle.js:223
      Custom Elements: `Element#insertAdjacentElement` was not patched.


Test Suites: 2 passed, 2 total
Tests:       2 passed, 2 total
Snapshots:   0 total
Time:        24.164s
Ran all test suites.

@AndyOGo AndyOGo added the bug Something isn't working label Oct 22, 2019
@AndyOGo AndyOGo self-assigned this Oct 22, 2019
@AndyOGo AndyOGo requested a review from LucaMele October 22, 2019 08:18
@AndyOGo AndyOGo mentioned this pull request Oct 22, 2019
Open
7 tasks
This was referenced Oct 22, 2019
Closed
Closed
AndyOGo
AndyOGo commented Oct 22, 2019
View reviewed changes
package.json
"dependencies": {
"@axa-ch/button": "^2.0.10",
"@axa-ch/patterns-library-polyfill": "^1.5.0",
"@webcomponents/webcomponentsjs": "^2.2.10",
Copy link
Contributor Author

@AndyOGo AndyOGo Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lock down is important!

Copy link
Contributor Author

@AndyOGo AndyOGo Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webcomponents/polyfills#222

Copy link
Contributor Author

@AndyOGo AndyOGo Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

axa-ch-webhub-cloud/pattern-library#1452

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@LucaMele LucaMele Awaiting requested review from LucaMele

Assignees

@AndyOGo AndyOGo

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyOGo