Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Including missing string.h for memcpy #1351

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Feb 17, 2025

No description provided.

Fixes
accept-test.c:39:2: error: call to undeclared library function 'memcpy' with type 'void *(void *, const void *, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Signed-off-by: Khem Raj <[email protected]>
Copy link
Contributor

@ammarfaizi2 ammarfaizi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's surprising...

How did we miss this?

It has never failed in GitHub CI, and no one has reported build errors.

It seems like a header must have been indirectly including <string.h>, but only under certain OS or environments.

@kraj
Copy link
Contributor Author

kraj commented Feb 18, 2025

That's surprising...

How did we miss this?

It has never failed in GitHub CI, and no one has reported build errors.

It seems like a header must have been indirectly including <string.h>, but only under certain OS or environments.

Yes. This is found with latest musl based systems. Musl tends to find the indirect includes issues which we do not see usually with glibc. This started to happen with faily recent musl

@axboe axboe merged commit 84c2c64 into axboe:master Feb 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants