feat: remove todos and update to v0.3.0 (#89)

* feat: use 0.8.19 * use 0.8.18 * remove todos * flatten is broken, remove it
axelarnetwork · Jul 18, 2023 · 4bbb2bc · 4bbb2bc
1 parent 59dfca6
commit 4bbb2bc
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/publish-bytecode.yaml b/.github/workflows/publish-bytecode.yaml
@@ -27,9 +27,6 @@ jobs:
       - name: Build
         run: npm run build
 
-      - name: Flatten contracts
-        run: npm run flatten
-
       - name: Get the tag
         id: release_tag
         run: echo ::set-output name=VERSION::${GITHUB_REF#refs/tags/}

diff --git a/contracts/interfaces/IERC20BurnableMintable.sol b/contracts/interfaces/IERC20BurnableMintable.sol
@@ -16,7 +16,6 @@ interface IERC20BurnableMintable is IERC20 {
      */
     function mint(address to, uint256 amount) external;
 
-    // TODO: need to understand what the common interface is for burning, burnFrom etc.
     /**
      * @notice Function to burn tokens
      * Can only be called by the distributor address.

diff --git a/contracts/token-implementations/ERC20Permit.sol b/contracts/token-implementations/ERC20Permit.sol
@@ -78,7 +78,6 @@ abstract contract ERC20Permit is IERC20, IERC20Permit, ERC20 {
 
         if (recoveredAddress != issuer) revert InvalidSignature();
 
-        // TODO: Add a unit test for this
         // _approve will revert if issuer is address(0x0)
         _approve(issuer, spender, value);
     }

diff --git a/hardhat.config.js b/hardhat.config.js
@@ -2,19 +2,18 @@ require('@nomicfoundation/hardhat-toolbox');
 require('solidity-coverage');
 require('solidity-docgen');
 
-const fs = require('fs');
 const env = process.env.ENV || 'testnet';
-const { importNetworks } = require('@axelar-network/axelar-contract-deployments/evm/utils');
+const { importNetworks, readJSON } = require('@axelar-network/axelar-contract-deployments/evm/utils');
 const chains = require(`@axelar-network/axelar-contract-deployments/info/${env}.json`);
-const keys = fs.existsSync(`${__dirname}/info/keys.json`) ? require(`${__dirname}/info/keys.json`) : undefined; // Load keys if they exist
+const keys = readJSON(`${__dirname}/info/keys.json`);
 const { networks, etherscan } = importNetworks(chains, keys);
 
 /**
  * @type import('hardhat/config').HardhatUserConfig
  */
 module.exports = {
     solidity: {
-        version: '0.8.17',
+        version: '0.8.18',
         settings: {
             evmVersion: process.env.EVM_VERSION || 'london',
             optimizer: {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@axelar-network/interchain-token-service",
-  "version": "0.2.0",
+  "version": "0.3.0",
   "main": "index.js",
   "scripts": {
     "test": "npx hardhat test",