Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not cache chain id for permit #106

Merged
merged 69 commits into from
Oct 3, 2023
Merged

feat: do not cache chain id for permit #106

merged 69 commits into from
Oct 3, 2023

Conversation

Foivos
Copy link
Contributor

@Foivos Foivos commented Sep 4, 2023 •
edited by jira bot
Loading

Foivos and others added 30 commits July 6, 2023 14:35
@Foivos
renamed folder and changed version
fbaded0
@Foivos
npmignore
8a6d845
@Foivos
npmignore
607de5c
@Foivos
Merge remote-tracking branch 'origin/main' into feat/dist
52fc054
@Foivos
change version
f5b5f56
@Foivos
using include pattern instead.
4c5738d
@Foivos
Merge remote-tracking branch 'origin/main' into feat/dist0-1-1
15e606b
@Foivos
Merge branch 'main' into feat/dist0-1-1
d998f1b
@Foivos
Fixed most of the things least auhority suggested.
0548a6e
@Foivos
made lint happy
8397b07
@milapsheth
Apply suggestions from code review
f2e5ea8
@Foivos
fixed some bugs
32ce490
@Foivos
Merge remote-tracking branch 'origin/main' into feat/least-autority-f…
80616c5 
…ixes
@Foivos
added events
dc516fe
@Foivos
rename set to transfer for distributor and operator
d6fa384
@Foivos
changed standardized token to always allow token managers to mint/bur…
5cc8fbb 
…n it.
@Foivos
using immutable storage for remoteAddressValidator address to save gas
ea255e0
@Foivos
Merge remote-tracking branch 'origin/main' into feat/gas-optimizations
09bf99a
@Foivos
Added some recommended changes
650ca71
@Foivos
added milap's suggested changes
c69e0a4
@Foivos
Merge remote-tracking branch 'origin/main' into feat/gas-optimizations
63a18e4
@Foivos
Fixed some names and some minor gas optimizations
2993930
@Foivos
prettier and lint
9074ed1
@Foivos
stash
d3cb150
@Foivos
import .env in hardhat.config
53fe6fe
@Foivos
trying to fix .env.example
7eb5207
@Foivos
Added some getters in IRemoteAddressValidator and removed useless che…
bf603eb 
…ck for distributor in the InterchainTokenService.
@Foivos
removed ternary operators
f1723c3
@Foivos
made lint happy
bc8ed59
@Foivos
Merge branch 'feat/gas-optimizations' into feat/use-create3-lib
7661e1f
Foivos and others added 19 commits July 28, 2023 23:21
@Foivos
Removed tokenManagerGetter and put params into tokenManagers
2e44518
@Foivos
Added separate tokenManager interfaces
6027ffe
@Foivos
addressed ackeeblockchains's 3.0 report
04041d1
@Foivos
prettier
6ee5d06
@Foivos
added interchain transfer methods to the service and unified receivin…
5acf4a8 
…g tokens a bit.
@Foivos
made lint happy
244ff61
@Foivos
rename sendToken to interchainTransfer
4e56576
@Foivos
changed sendToken everywhere
a8dc8a4
@Foivos
changed from uint256.max to a const
b210316
@Foivos
change setting to zero to delete for storage slots.
2f5adac
@Foivos
rearange storage variables to save a bit of gas.
af4766a
@Foivos
Removed unecesairy casts
634581c
@Foivos
made as many event params inexed as possible
141648b
@Foivos
Removed unused imports
602d531
@Foivos
domain separator is calculated each time.
0ec429e
@Foivos
added some natspec
f089d50
@re1ro
Merge branch 'main' into feat/move-views-out-of-serivce
5cf5ea5 
# Conflicts:
#	contracts/interchain-token-service/InterchainTokenService.sol
#	contracts/remote-address-validator/RemoteAddressValidator.sol
#	contracts/token-manager/implementations/TokenManagerLiquidityPool.sol
#	contracts/token-manager/implementations/TokenManagerLockUnlock.sol
#	contracts/token-manager/implementations/TokenManagerLockUnlockFeeOnTransfer.sol
#	contracts/utils/StandardizedTokenDeployer.sol
@re1ro
Merge branch 'feat/move-views-out-of-serivce' into feat/ackee-3.0
ab32389 
# Conflicts:
#	contracts/interchain-token-service/InterchainTokenService.sol
#	contracts/interfaces/IRemoteAddressValidator.sol
#	contracts/proxies/TokenManagerProxy.sol
#	contracts/remote-address-validator/RemoteAddressValidator.sol
@re1ro
Merge branch 'feat/ackee-3.0' into feat/interchain-transsfer-everywhere
8a21176 
# Conflicts:
#	contracts/utils/ExpressCallHandler.sol
#	docs/index.md
Base automatically changed from feat/code4rena-gas-opts to main October 2, 2023 15:09
@milapsheth milapsheth merged commit 4ca3dd6 into main Oct 3, 2023
3 checks passed
@milapsheth milapsheth deleted the feat/do-not-cache-chain-id-for-permit branch October 3, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

@re1ro re1ro re1ro approved these changes

@deanamiel deanamiel Awaiting requested review from deanamiel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Foivos @re1ro @milapsheth