Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clone instead of fixed proxy #168

Merged
merged 15 commits into from
Nov 13, 2023
Merged

feat: clone instead of fixed proxy #168

merged 15 commits into from
Nov 13, 2023

Conversation

Foivos
Copy link
Contributor

@Foivos Foivos commented Nov 8, 2023

This saves 65k gas per interchainToken deployment and 100 gas per call to the interchain token. I deem it worthwile

@Foivos Foivos requested a review from a team as a code owner November 8, 2023 13:39
blockchainguyy
blockchainguyy approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@blockchainguyy blockchainguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

milapsheth
milapsheth reviewed Nov 8, 2023
View reviewed changes
contracts/utils/InterchainTokenDeployer.sol Outdated Show resolved Hide resolved
contracts/interchain-token/InterchainToken.sol Outdated Show resolved Hide resolved
contracts/interchain-token/InterchainToken.sol Outdated Show resolved Hide resolved
contracts/interchain-token/InterchainToken.sol Outdated Show resolved Hide resolved
contracts/interchain-token/InterchainToken.sol Outdated Show resolved Hide resolved
contracts/interchain-token/InterchainToken.sol Outdated Show resolved Hide resolved
contracts/interchain-token/InterchainToken.sol Outdated Show resolved Hide resolved
contracts/interfaces/IInterchainToken.sol Outdated Show resolved Hide resolved
contracts/utils/InterchainTokenDeployer.sol Outdated Show resolved Hide resolved
@re1ro
Copy link
Contributor

re1ro commented Nov 13, 2023

Looks good and it's a huge improvement. Let's refactor CloneProxy into a lib.
Also would make sense to add comments for the bytecode constants from ERC-1167 and reference to the standard.

@re1ro re1ro merged commit 74e2524 into main Nov 13, 2023
4 checks passed
@re1ro re1ro deleted the feat/clone-instead-of-fixed-proxy branch November 13, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockchainguyy blockchainguyy blockchainguyy approved these changes

@milapsheth milapsheth milapsheth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Foivos @re1ro @milapsheth @blockchainguyy