feat: reduce codesize #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added new token managers that have the mint/burn permissions. * added a few tests * a few more tests * removed mint/burn from legacy * rename INTERCHAIN_TOKEN to INTERCHAIN_TOKEN_MINT_BURN * remove unused import and prettier * some more renaming * rever * added some docstrings * prettier * chore: restrict custom token manager deployments (#3) * some styling * fixed revert * fixed some docs * bump package version * restrict remote token manager deployment * rename MINT_BURN_FROM to CUSTOM_MINT_BURN_FROM * prettier * add comments to TokenManagerType * rename token manager types * update docs * refactor(TokenManager): simplification (#4) * refactor(TokenManager): simplification * refactor(TokenManager): unused import * update doc --------- Co-authored-by: Milap Sheth <[email protected]> Co-authored-by: re1ro <[email protected]>
…new-token-managers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/merge-new-token-managers #262 +/- ##
=================================================================
- Coverage 97.56% 97.23% -0.33%
=================================================================
Files 18 18
Lines 574 578 +4
Branches 115 117 +2
=================================================================
+ Hits 560 562 +2
Misses 5 5
- Partials 9 11 +2 ☔ View full report in Codecov by Sentry. |
re1ro
approved these changes
Apr 15, 2024
|
@Foivos this would also require deploy/upgrade scripts updates right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move more code to token-handler