-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: preventing original chain name & destination chain name are the same #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahramy
changed the title
fix: preventing original chain name & destination chan name are the same
fix: preventing original chain name & destination chain name are the same
Sep 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
- Coverage 97.70% 97.68% -0.02%
==========================================
Files 19 19
Lines 609 604 -5
Branches 125 127 +2
==========================================
- Hits 595 590 -5
Misses 5 5
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
milapsheth
reviewed
Sep 10, 2024
Foivos
approved these changes
Sep 10, 2024
milapsheth
reviewed
Sep 16, 2024
milapsheth
requested changes
Sep 17, 2024
InterchainTokenFactory.deployRemoteInterchainToken(string,bytes32,address,string,uint256).chainNameHash_ (contracts/InterchainTokenFactory.sol#204) is a local variable never initialized InterchainTokenFactory.deployRemoteCanonicalInterchainToken(string,address,string,uint256).chainNameHash_ (contracts/InterchainTokenFactory.sol#336) is a local variable never initialized
milapsheth
reviewed
Sep 25, 2024
milapsheth
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-4776
InterchainTokenFactory.deployRemoteInterchainToken
, check ifdestinationChain
is the same asoriginalChainName
to prevent remote deployment requests to the original chain.InterchainTokenFactory.deployRemoteCanonicalInterchainToken
to ensure that a remote deploy cannot be requested to the original chain.InterchainTokenFactory.sol
andInterchainTokenService.sol