Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modified wrong data decoding in _checkPayloadAgainstGatewayData #278

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix: modified wrong data decoding in _checkPayloadAgainstGatewayData #278

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb3e445
fix: modified wrong data decoding in _checkPayloadAgainstGatewayData
ahramy Sep 17, 2024
dc1df56
added comment
ahramy Sep 17, 2024
442f2a9
updated code
ahramy Sep 17, 2024
1b8f960
updated
ahramy Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contracts/InterchainTokenService.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,8 @@ contract InterchainTokenService is
* @param amount The amount for the call contract with token.
*/
function _checkPayloadAgainstGatewayData(bytes memory payload, string calldata tokenSymbol, uint256 amount) internal view {
// The same payload is decoded in both _checkPayloadAgainstGatewayData and _contractCallValue using different parameters.
// This is intentional, as using `uint256` instead of `bytes` improves gas efficiency without any functional difference.
(, bytes32 tokenId, , , uint256 amountInPayload) = abi.decode(payload, (uint256, bytes32, uint256, uint256, uint256));

if (validTokenAddress(tokenId) != gateway.tokenAddresses(tokenSymbol) || amount != amountInPayload)
Expand Down
Loading