feat(its-factory): allow minter to be arbitrary bytes for remote token deployment #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahramy
changed the title
Foivos
reviewed
Nov 6, 2024
Foivos
reviewed
Nov 8, 2024
|
|
||
| tokenId = deployRemoteInterchainToken(salt, minter, destinationChain, gasValue); | ||
| tokenId = deployRemoteInterchainToken(salt, minter_, destinationChain, gasValue); |
There was a problem hiding this comment.
this is incosistent with the other function. I think we should not have the same function name twice in the same contract anyway, and this function does nothing for now, since the additional parameter has to be empty. If you wanna add the parameter now and support it later then maybe remove the other function completely. If you need both you should have an internal function that executes the logic and have both external functions call it to avoid the extra external call, which I think is what happens here (test this i might be wrong).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AXE-6319