Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform support and a workaround for consult chars outside unicode in native module #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sashimacs
Copy link
Contributor

I have a couple minor changes suggested in this PR:

(advice-add 'hotfuzz--filter-c :around #'hotfuzz--fix-tofu-chars)

The consult workaround has some helper functions from https://github.com/magnars/dash.el which I pulled in to avoid having a whole dependency on dash, but can also refactor them and add a dependency if you think it's worth it.

@jwr
Copy link

jwr commented Mar 26, 2024

FWIW, this advice-add fixed the breakage with consult for me nicely. It seems it wasn't pulled into the main hotfuzz codebase, though.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.85%. Comparing base (6223294) to head (9b1cac9).

Files Patch % Lines
hotfuzz.el 59.09% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   93.50%   85.85%   -7.65%     
==========================================
  Files           1        1              
  Lines          77       99      +22     
==========================================
+ Hits           72       85      +13     
- Misses          5       14       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants