Cross-platform support and a workaround for consult chars outside unicode in native module#13
Open
sashimacs wants to merge 4 commits intoaxelf4:masterfrom
Open
Cross-platform support and a workaround for consult chars outside unicode in native module#13sashimacs wants to merge 4 commits intoaxelf4:masterfrom
sashimacs wants to merge 4 commits intoaxelf4:masterfrom
Conversation
|
FWIW, this |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 93.50% 85.85% -7.65%
==========================================
Files 1 1
Lines 77 99 +22
==========================================
+ Hits 72 85 +13
- Misses 5 14 +9 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a couple minor changes suggested in this PR:
*u8string literals are not available in C99 (cpp references says since C11), so bumpedC_STANDARDsysinfo/get_nprocs()is unavailable on macOS so I'm usingsysconfto get processor count.hotfuzz--fix-tofu-charsto add as advice on native filtering to fix issues with consult-multi tofu characters outside unicode range, e.g. Getting hotfuzz-module to play nicely with consult #12, used like:The consult workaround has some helper functions from https://github.com/magnars/dash.el which I pulled in to avoid having a whole dependency on dash, but can also refactor them and add a dependency if you think it's worth it.