-
Notifications
You must be signed in to change notification settings - Fork 11
Add support for token management #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Left some comments, most of them rather trivial. One bigger change I wanna discuss is the package level capabilities API. My feeling is that the capabilities should be typed (permissions?). E.g.: cap := map[string]DatasetCapabilities{
"dataset": {
Ingest: []string{"create"},
Query: []string{"read"},
},
} becomes: cap := map[string]DatasetCapabilities{
"dataset": {
Ingest: []Permission{PermissionCreate},
Query: []Permission{PermissionRead},
},
} Maybe For an implementation, see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three mini fixes. But please do add the unit tests for Action
, tho.
No description provided.