Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations cmd #238

Merged
merged 12 commits into from
Jun 12, 2024
Merged

Add annotations cmd #238

merged 12 commits into from
Jun 12, 2024

Conversation

bahlo
Copy link
Member

@bahlo bahlo commented Jun 10, 2024

This adds support for axiom annotations create|list|update|delete.
Depends on axiomhq/axiom-go#317.

@bahlo bahlo requested a review from lukasmalkmus June 10, 2024 15:20
@bahlo bahlo marked this pull request as ready for review June 10, 2024 15:24
@bahlo bahlo force-pushed the arne/axm-3952-add-annotations-to-cli branch from 33cc3d6 to 5d62a2b Compare June 11, 2024 07:44
Copy link

This PR/issue depends on:

lukasmalkmus
lukasmalkmus previously approved these changes Jun 12, 2024
Copy link
Collaborator

@lukasmalkmus lukasmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you might need to rebase, tho.

internal/cmd/dataset/dataset_trim.go Show resolved Hide resolved
internal/cmd/dataset/dataset_trim.go Outdated Show resolved Hide resolved
internal/cmd/dataset/dataset_trim.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@lukasmalkmus lukasmalkmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasmalkmus lukasmalkmus enabled auto-merge (rebase) June 12, 2024 15:23
@lukasmalkmus lukasmalkmus force-pushed the arne/axm-3952-add-annotations-to-cli branch from 02aade8 to 69e265b Compare June 12, 2024 15:26
@lukasmalkmus lukasmalkmus merged commit 3147c4a into main Jun 12, 2024
7 checks passed
@lukasmalkmus lukasmalkmus deleted the arne/axm-3952-add-annotations-to-cli branch June 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants