Skip to content

Update and re-enable Scene3D test #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025
Merged

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Jun 5, 2025

Describe your changes

The Scene3DTest.cpp/.h were never updated during the transition from Cocos2d-x v3 to v4, and it has remained that way during the porting to Axmol, since it was never part of the build (disabled in CMakeLists.txt) to be noticed. It's now updated, and works, but may have some bugs.

I'm not quite sure what this line is for, or what to change it to in Axmol, so I would appreciate some guidance:

RenderState::StateBlock::invalidate(ax::RenderState::StateBlock::RS_ALL_ONES);

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added this to the next milestone Jun 6, 2025
@halx99 halx99 merged commit f225f94 into axmolengine:dev Jun 6, 2025
15 checks passed
@rh101 rh101 deleted the cpp-tests-scene3d branch June 6, 2025 23:46
@halx99 halx99 modified the milestones: next, 2.7.0 Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants