-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for zoneinfo objects #849
Open
nikvst
wants to merge
95
commits into
axnsan12:master
Choose a base branch
from
nikvst:add-support-for-zoneinfo-timezone-field
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added support for zoneinfo objects #849
nikvst
wants to merge
95
commits into
axnsan12:master
from
nikvst:add-support-for-zoneinfo-timezone-field
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`permission_classes` expects tuple but list was provided
fix a bug: url from swagger_settings.DEFAULT_API_URL is not working
Check for allow_null attribute
This change fixes an `OPTIONS` request to the API page which will return a successful response, but the `TemplateHTMLRender` will not be prepared to render it since there is no template name provided in either the view or response [1]. [1]: https://github.com/encode/django-rest-framework/blob/f0a5b958a134e8cd94e3ef3263e8fa623ac9b82f/rest_framework/renderers.py#L178-L189
fix map source mapping
[readme] Fix missing re_path import
Add utf-8 support for generated formats
Remove universal wheel, python 2 is unsupported
…j-drf Run tests with latest dependencies
…r-ordering keep path parameters in their given order
Django master branch bumped minimal python version to Python 3.10. In latest version was added check for uniq basename.
Fix: Provide support for enums in codecs.
* Feature: Migrate to PyYAML for yaml generator. Closes axnsan12#833 * Chore: Update swagger ui and redoc dependencies.
nikvst
changed the title
add support for working with zoneinfo object field
Add support for working with zoneinfo object field
May 18, 2023
nikvst
changed the title
Add support for working with zoneinfo object field
Added support for zoneinfo objects
Jun 5, 2023
yuekui
reviewed
Dec 5, 2023
nikvst
force-pushed
the
add-support-for-zoneinfo-timezone-field
branch
from
December 5, 2023 07:46
bc02a0d
to
0c73a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as #717, but for zoneinfo objects.
I ran into a problem because django is migrating from pytz to ZoneInfo and is planning to remove pytz support from django 5.0.
If this change requires tests, where should I add them?
Thanks