Feedback Cycle 2: Linter/Formatter

Author: edusta

.swiftformat

@@ -0,0 +1,10 @@
+--exclude **/Pods
+--exclude **/DerivedData
+--exclude **/Build
+
+# Thiese rules clashes with SwiftLint.
+--disable wrapMultilineStatementBraces
+--disable trailingCommas
+
+# Wrapping
+--maxwidth 120

.swiftlint.yml

@@ -0,0 +1,5 @@
+reporter: "xcode"
+
+disabled_rules:
+    - force_cast
+    - identifier_name

Features/StatusBarController.swift

@@ -6,14 +6,14 @@
 //
 
 import Cocoa
-import SwiftUI
 import ServiceManagement
+import SwiftUI
 
 class StatusBarController: ObservableObject {
     static let shared = StatusBarController()
     private var statusItem: NSStatusItem?
     private let windowManager = WindowManager.shared
-    
+
     private init() {
         DispatchQueue.main.async {
             self.statusItem = NSStatusBar.system.statusItem(withLength: NSStatusItem.squareLength)
@@ -22,126 +22,130 @@ class StatusBarController: ObservableObject {
             self.setupLoginItem()
         }
     }
-    
+
     private func setupLoginItem() {
         if let bundleIdentifier = Bundle.main.bundleIdentifier {
             if !SMLoginItemSetEnabled(bundleIdentifier as CFString, true) {
                 print("Login item eklenemedi")
             }
         }
     }
-    
+
     private func setupUI() {
         if let button = statusItem?.button {
             button.image = NSImage(systemSymbolName: "rectangle.split.3x1", accessibilityDescription: nil)
         }
     }
-    
+
     private func setupMenus() {
         let menu = NSMenu()
-        
+
         // 2/3 Split Menu Items
         let leftTwoThirdsItem = NSMenuItem(title: "Left 2/3", action: #selector(leftTwoThirds), keyEquivalent: "")
         leftTwoThirdsItem.target = self
         menu.addItem(leftTwoThirdsItem)
-        
+
         let rightTwoThirdsItem = NSMenuItem(title: "Right 2/3", action: #selector(rightTwoThirds), keyEquivalent: "")
         rightTwoThirdsItem.target = self
         menu.addItem(rightTwoThirdsItem)
-        
+
         menu.addItem(NSMenuItem.separator())
-        
+
         // 1/3 Split Menu Items
         let leftThirdItem = NSMenuItem(title: "Left 1/3", action: #selector(leftThird), keyEquivalent: "")
         leftThirdItem.target = self
         menu.addItem(leftThirdItem)
-        
+
         let centerThirdItem = NSMenuItem(title: "Center 1/3", action: #selector(centerThird), keyEquivalent: "")
         centerThirdItem.target = self
         menu.addItem(centerThirdItem)
-        
+
         let rightThirdItem = NSMenuItem(title: "Right 1/3", action: #selector(rightThird), keyEquivalent: "")
         rightThirdItem.target = self
         menu.addItem(rightThirdItem)
-        
+
         menu.addItem(NSMenuItem.separator())
-        
+
         // Half Split Menu Items
         let leftHalfItem = NSMenuItem(title: "Left Half", action: #selector(leftHalf), keyEquivalent: "")
         leftHalfItem.target = self
         menu.addItem(leftHalfItem)
-        
+
         let rightHalfItem = NSMenuItem(title: "Right Half", action: #selector(rightHalf), keyEquivalent: "")
         rightHalfItem.target = self
         menu.addItem(rightHalfItem)
-        
+
         menu.addItem(NSMenuItem.separator())
-        
+
         // Corner Controls
         let cornersSubmenu = NSMenu()
-        
+
         let topLeftItem = NSMenuItem(title: "Top Left", action: #selector(topLeft), keyEquivalent: "")
         topLeftItem.target = self
         cornersSubmenu.addItem(topLeftItem)
-        
+
         let topRightItem = NSMenuItem(title: "Top Right", action: #selector(topRight), keyEquivalent: "")
         topRightItem.target = self
         cornersSubmenu.addItem(topRightItem)
-        
+
         let bottomLeftItem = NSMenuItem(title: "Bottom Left", action: #selector(bottomLeft), keyEquivalent: "")
         bottomLeftItem.target = self
         cornersSubmenu.addItem(bottomLeftItem)
-        
+
         let bottomRightItem = NSMenuItem(title: "Bottom Right", action: #selector(bottomRight), keyEquivalent: "")
         bottomRightItem.target = self
         cornersSubmenu.addItem(bottomRightItem)
-        
+
         let cornersItem = NSMenuItem(title: "Corners", action: nil, keyEquivalent: "")
         cornersItem.submenu = cornersSubmenu
         menu.addItem(cornersItem)
-        
+
         // Vertical Split
         let verticalSubmenu = NSMenu()
-        
+
         let topHalfItem = NSMenuItem(title: "Top Half", action: #selector(topHalf), keyEquivalent: "")
         topHalfItem.target = self
         verticalSubmenu.addItem(topHalfItem)
-        
+
         let bottomHalfItem = NSMenuItem(title: "Bottom Half", action: #selector(bottomHalf), keyEquivalent: "")
         bottomHalfItem.target = self
         verticalSubmenu.addItem(bottomHalfItem)
-        
+
         let verticalItem = NSMenuItem(title: "Vertical Split", action: nil, keyEquivalent: "")
         verticalItem.submenu = verticalSubmenu
         menu.addItem(verticalItem)
-        
+
         menu.addItem(NSMenuItem.separator())
-        
+
         // Other Controls
         let centerItem = NSMenuItem(title: "Center", action: #selector(center), keyEquivalent: "")
         centerItem.target = self
         menu.addItem(centerItem)
-        
+
         let fullScreenItem = NSMenuItem(title: "Full Screen", action: #selector(fullScreen), keyEquivalent: "")
         fullScreenItem.target = self
         menu.addItem(fullScreenItem)
-        
+
         menu.addItem(NSMenuItem.separator())
-        
+
         // Launch at Login option
-        let launchAtLoginItem = NSMenuItem(title: "Launch at Login", action: #selector(toggleLaunchAtLogin), keyEquivalent: "")
+        let launchAtLoginItem = NSMenuItem(
+            title: "Launch at Login",
+            action: #selector(toggleLaunchAtLogin),
+            keyEquivalent: ""
+        )
         launchAtLoginItem.target = self
         launchAtLoginItem.state = isLoginItemEnabled() ? .on : .off
         menu.addItem(launchAtLoginItem)
-        
+
         menu.addItem(NSMenuItem.separator())
-        
+
         let quitItem = NSMenuItem(title: "Quit", action: #selector(NSApplication.terminate(_:)), keyEquivalent: "q")
         menu.addItem(quitItem)
-        
+
         statusItem?.menu = menu
     }
-    
+
     private func isLoginItemEnabled() -> Bool {
         if let bundleIdentifier = Bundle.main.bundleIdentifier {
             for app in NSWorkspace.shared.runningApplications {
@@ -152,7 +156,7 @@ class StatusBarController: ObservableObject {
         }
         return false
     }
-    
+
     @objc private func toggleLaunchAtLogin() {
         if let bundleIdentifier = Bundle.main.bundleIdentifier {
             let currentState = isLoginItemEnabled()
@@ -162,97 +166,97 @@ class StatusBarController: ObservableObject {
             }
         }
     }
-    
+
     // 2/3 Split Actions
     @objc private func leftTwoThirds() {
         DispatchQueue.main.async {
             self.windowManager.divideScreenIntoTwoThirds(position: .left)
         }
     }
-    
+
     @objc private func rightTwoThirds() {
         DispatchQueue.main.async {
             self.windowManager.divideScreenIntoTwoThirds(position: .right)
         }
     }
-    
+
     // 1/3 Split Actions
     @objc private func leftThird() {
         DispatchQueue.main.async {
             self.windowManager.resize(.third(.left))
         }
     }
-    
+
     @objc private func centerThird() {
         DispatchQueue.main.async {
             self.windowManager.resize(.third(.center))
         }
     }
-    
+
     @objc private func rightThird() {
         DispatchQueue.main.async {
             self.windowManager.resize(.third(.right))
         }
     }
-    
+
     // Half Split Actions
     @objc private func leftHalf() {
         DispatchQueue.main.async {
             self.windowManager.resize(.half(.left))
         }
     }
-    
+
     @objc private func rightHalf() {
         DispatchQueue.main.async {
             self.windowManager.resize(.half(.right))
         }
     }
-    
+
     // Corner Actions
     @objc private func topLeft() {
         DispatchQueue.main.async {
             self.windowManager.resize(.corner(.topLeft))
         }
     }
-    
+
     @objc private func topRight() {
         DispatchQueue.main.async {
             self.windowManager.resize(.corner(.topRight))
         }
     }
-    
+
     @objc private func bottomLeft() {
         DispatchQueue.main.async {
             self.windowManager.resize(.corner(.bottomLeft))
         }
     }
-    
+
     @objc private func bottomRight() {
         DispatchQueue.main.async {
             self.windowManager.resize(.corner(.bottomRight))
         }
     }
-    
+
     // Vertical Split Actions
     @objc private func topHalf() {
         DispatchQueue.main.async {
             self.windowManager.resize(.vertical(.top))
         }
     }
-    
+
     @objc private func bottomHalf() {
         DispatchQueue.main.async {
             self.windowManager.resize(.vertical(.bottom))
         }
     }
-    
+
     // Other Actions
     @objc private func center() {
         DispatchQueue.main.async {
             self.windowManager.resize(.generic(.center))
         }
     }
-    
+
     @objc private func fullScreen() {
         DispatchQueue.main.async {
             self.windowManager.resize(.generic(.fullScreen))

Features/StatusBarView.swift

@@ -9,7 +9,7 @@ import SwiftUI
 
 struct StatusBarView: View {
     let windowManager = WindowManager.shared
-    
+
     var body: some View {
         VStack(spacing: 8) {
             Group {
@@ -25,9 +25,9 @@ struct StatusBarView: View {
                         Label("Right 1/3", systemImage: "rectangle.righthalf.filled")
                     }
                 }
-                
+
                 Divider()
-                
+
                 // Options for half split
                 HStack {
                     Button(action: { windowManager.resize(.half(.left)) }) {
@@ -37,9 +37,9 @@ struct StatusBarView: View {
                         Label("Right Half", systemImage: "rectangle.righthalf.filled")
                     }
                 }
-                
+
                 Divider()
-                
+
                 // Corner options
                 Grid {
                     GridRow {
@@ -54,14 +54,14 @@ struct StatusBarView: View {
                         Button(action: { windowManager.resize(.corner(.bottomLeft)) }) {
                             Label("Bottom Left", systemImage: "arrow.down.left.square")
                         }
-                        Button(action: {windowManager.resize(.corner(.bottomRight)) }) {
+                        Button(action: { windowManager.resize(.corner(.bottomRight)) }) {
                             Label("Bottom Right", systemImage: "arrow.down.right.square")
                         }
                     }
                 }
-                
+
                 Divider()
-                
+
                 // Other options
                 HStack {
                     Button(action: { windowManager.resize(.vertical(.top)) }) {
@@ -71,19 +71,19 @@ struct StatusBarView: View {
                         Label("Bottom Half", systemImage: "rectangle.bottomhalf.filled")
                     }
                 }
-                
+
                 Button(action: { windowManager.resize(.generic(.fullScreen)) }) {
                     Label("Full Screen", systemImage: "rectangle.fill")
                 }
-                
+
                 Button(action: { windowManager.resize(.generic(.center)) }) {
                     Label("Center", systemImage: "rectangle.center.filled")
                 }
             }
             .buttonStyle(.bordered)
-            
+
             Divider()
-            
+
             Button("Exit") {
                 NSApplication.shared.terminate(nil)
             }