Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3228: Change featured image to thumbnail image in Marketing Cloud layouts #3847

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

danahertzberg
Copy link
Contributor

@danahertzberg danahertzberg commented Oct 30, 2024

Description

This PR changes the Marketing Cloud layouts to use the thumbnail image instead of the featured image.

Question: If the thumbnail image is not populated, should we fill it in with the placeholder image or the featured image?
Answer: Need help with populating with featured image if no thumbnail, and placeholder if no featured image.

Release notes

Marketing Cloud layouts now use the Thumbnail Image field for news images, replacing the previously used Featured Image field, and setting the Featured Image field as the fallback.

Related issues

Closes #3228

How to test

  1. Install the AZ Marketing Cloud module
  2. Change the thumbnail image on a news item
  3. View that news item's marketing cloud layout to observe thumbnail use

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@danahertzberg danahertzberg linked an issue Oct 30, 2024 that may be closed by this pull request
@danahertzberg danahertzberg self-assigned this Oct 30, 2024
@HenryzGreenberg
Copy link

If the thumbnail image is unavailable, using the featured image as a fallback is best. This ensures that the content remains visually consistent.

@trackleft
Copy link
Member

trackleft commented Oct 30, 2024

What do you think of this for the release notes?

Marketing Cloud layouts now use the Thumbnail field for news images, replacing the previously used Featured Image field, and setting the Featured Image field as the fallback.

@danahertzberg danahertzberg marked this pull request as ready for review October 30, 2024 20:01
@danahertzberg danahertzberg requested a review from a team as a code owner October 30, 2024 20:01
@danahertzberg danahertzberg added the Integrations This relates to an integration into a central service. label Oct 30, 2024
@danahertzberg
Copy link
Contributor Author

danahertzberg commented Oct 31, 2024

Dana to send to Paul Fini for review -- Emailed on 11/1/2024

Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Potential future improvement: in the "Content for email" admin view, disable links for news layouts with images (Hero, 50/50, etc.) for news nodes that don't have a featured or thumbnail image.

@danahertzberg
Copy link
Contributor Author

Talked with Paul yesterday and no concerns were brought up

@bberndt-uaz bberndt-uaz added 2.12.x only patch release Issues to be included in the next patch release labels Nov 6, 2024
@bberndt-uaz bberndt-uaz merged commit 9266c51 into main Nov 6, 2024
16 checks passed
@bberndt-uaz bberndt-uaz deleted the issue/3228 branch November 6, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only Integrations This relates to an integration into a central service. patch release Issues to be included in the next patch release release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use thumbnail image in Marketing Cloud newsletters
6 participants