Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3850: Update Quickstart content type views to have sticky at top of lists respected #3851

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

danahertzberg
Copy link
Contributor

@danahertzberg danahertzberg commented Oct 31, 2024

Description

This adds a stick at top of lists sort criteria to all views.

Release notes

If this change requires release notes: provide a summary of changes, how to use this change, and any related links. This content will be pasted in the release notes. Use markdown format to ensure proper pasting of information. Release notes example

Make sure to add the release notes label to this PR.

Views of AZ Person, AZ News, AZ Event, and AZ Page are updated to respect the "Sticky at top of lists" setting found on an individual piece of content. Content with this setting will now appear at the top of views.

Related issues

Closes #3850

How to test

  1. Modify content to check the "Sticky at top of lists" box
  2. Add a page with a view of that same content type
  3. Observe selected content at the top of the list

Changed view displays include:

  • AZ Events
    • Grid view
    • Grid view with images
  • AZ News
    • Feature view
    • Paged row view
    • Small row view
    • Grid view
    • Grid view with filter
    • Teaser grid page
    • Recent news marquee
    • Row attachment
  • AZ Pages
    • Row page
    • Grid page
  • AZ Person
    • Grid page
    • Grid - modal
    • Row page
    • Grid - 3 col
    • Grid - Modal 3 col

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@danahertzberg danahertzberg self-assigned this Oct 31, 2024
@danahertzberg danahertzberg requested a review from a team as a code owner October 31, 2024 14:27
@danahertzberg danahertzberg linked an issue Oct 31, 2024 that may be closed by this pull request
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Probo, I'm only seeing the "Sticky at top of lists" sort criterion on the AZ News Feature view display (and it does seem to be working there). I wonder if you need to add that criterion to the view displays individually.

@danahertzberg
Copy link
Contributor Author

AZ News Feature view display (and it does seem to be working there). I wonder if you need to add that criterion to the view displays individually.

So weird, on my local I updated the default display and ensured the other displays were using the default when appropriate and it seemed fine there. I'll look into it more. :(

@danahertzberg
Copy link
Contributor Author

danahertzberg commented Nov 1, 2024

I bet it's something with demo content. I'll look again to see if there are overridden views for demo content.

Ah -- it's finder. I'll update.

This reverts commit 7ad9d83.
@danahertzberg danahertzberg marked this pull request as draft November 1, 2024 15:55
@danahertzberg danahertzberg marked this pull request as ready for review November 5, 2024 16:25
@danahertzberg
Copy link
Contributor Author

danahertzberg commented Nov 6, 2024

To do:

  • Change AZ Person to update overridden views instead of reverting to default
    • Add back contextual filter
  • Update finder views
  • Export AZ Event changes from probo

@bberndt-uaz
Copy link
Contributor

bberndt-uaz commented Nov 12, 2024

I noticed that the Small Row View view display from the AZ News view has the Block Name Sidebar News Block. It looks like that was changed to Small Row News Block in the AZ News view from the az_finder module, but not the original view from the az_news module. If you want to make that change in this PR (instead of opening another issue for it), here is the relevant line from the issue/3850 branch: https://github.com/az-digital/az_quickstart/blob/issue/3850/modules/custom/az_news/config/install/views.view.az_news.yml#L906.

Also, I wanted to double-check if the AZ News Sidebar Row View should have the "Sticky at top of lists" sorting? I can't recall what we decided on last week. Otherwise, I'm ready to approve this PR once the request above is resolved!

@danahertzberg
Copy link
Contributor Author

I noticed that the Small Row View view display from the AZ News view has the Block Name Sidebar News Block. It looks like that was changed to Small Row News Block in the AZ News view from the az_finder module, but not the original view from the az_news module. If you want to make that change in this PR (instead of opening another issue for it), here is the relevant line from the issue/3850 branch: https://github.com/az-digital/az_quickstart/blob/issue/3850/modules/custom/az_news/config/install/views.view.az_news.yml#L906.

Also, I wanted to double-check if the AZ News Sidebar Row View should have the "Sticky at top of lists" sorting? I can't recall what we decided on last week. Otherwise, I'm ready to approve this PR once the request above is resolved!

Thanks @bberndt-uaz! I updated the block name -- good catch! And I think the sidebar stickiness we wanted to cover in the meeting to get group consensus.

bberndt-uaz
bberndt-uaz previously approved these changes Nov 13, 2024
@danahertzberg
Copy link
Contributor Author

danahertzberg commented Nov 13, 2024

  • Need to test on news.arizona.edu after CWS fixes GH action
  • Sidebar row view -- Should this respect sticky articles? No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

Add sticky to top of lists in sort criteria
2 participants