Skip to content

video_core/renderer_vulkan: Add texture filtering #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbm11208
Copy link
Contributor

@jbm11208 jbm11208 commented Jun 5, 2025

Addresses #890

@jbm11208 jbm11208 marked this pull request as ready for review June 5, 2025 00:55
@OpenSauce04 OpenSauce04 requested a review from PabloMK7 June 5, 2025 07:01
@OpenSauce04 OpenSauce04 force-pushed the vulkan-texture-filter branch from dcf2ec6 to 3127b2c Compare June 9, 2025 18:36
vk::Pipeline MakeFilterPipeline(vk::ShaderModule fragment_shader, vk::PipelineLayout layout);

void FilterAnime4K(Surface& surface, const VideoCore::TextureBlit& blit);
void FilterBicubic(Surface& surface, const VideoCore::TextureBlit& blit);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VK_IMG_filter_cubic can possibly be utilized here to remove the need to use a full graphics pipeline in favor of a simpler vkCmdBlitImage-operation if this filter is available.

A lot of mobile devices feature it in particular as well as Snapdragon-based Windows-on-Arm laptops.

@OpenSauce04 OpenSauce04 added the bug Something isn't working label Jun 18, 2025
@PabloMK7 PabloMK7 self-assigned this Jun 23, 2025
@jbm11208
Copy link
Contributor Author

Been very busy lately, probably won't have time to work on this for at least a month or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants