Use MacOS-specific refresh rate check to avoid SDL race condition #1262
+28
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSauce04
force-pushed
the
macos-refreshrate-check
branch
from
f5bde2c to
34d4842
Compare
PabloMK7
requested changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because MacOS is very sensitive when it comes to what is allowed to be done on non-main threads, if the input thread called
SDL_PumpEventwhile we were betweenSDL_InitandSDL_QuitSubSystemin the prior code, the emulator would completely crash.To avoid this, we now use a MacOS-specific implementation of the refresh rate check which takes SDL out of the equation entirely, and as other OSes aren't as thread-sensitive, this should resolve the issue completely.