Skip to content

Refactor NetSettings into normal core settings & Add UI for configuring web_service related settings #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Refactor NetSettings into normal core settings & Add UI for configuring web_service related settings #831

wants to merge 8 commits into from
+177 −106

Conversation

OpenSauce04
Copy link
Member

Re-opened from #684

This PR does 2 main things

  • Moves citra-username, web_api_url and citra_token net settings into normal setting under core/settings.h

I am not sure why this was done this way but having them under core settings made the 2nd point easier, so I went ahead and moved them

  • Add UI settings on qt and Android for citra-username, web_api_url and citra_token

Related to the Handle usernames better task on #667 as well as I plan to match parity with qt and use citra-username for the default multiplayer name

@OpenSauce04 OpenSauce04 added enhancement New feature or request refactor Internal changes which are minimally visible labels Mar 25, 2025
@OpenSauce04 OpenSauce04 added this to the 2123 milestone Mar 25, 2025
@OpenSauce04 OpenSauce04 self-assigned this Mar 25, 2025
toksn
toksn reviewed Mar 26, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toksn toksn toksn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@OpenSauce04 OpenSauce04

Labels
enhancement New feature or request manual merge refactor Internal changes which are minimally visible size/L
Projects
None yet
Milestone
2123
Development

Successfully merging this pull request may close these issues.
2 participants
@OpenSauce04 @toksn