Apply patch of say.js #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azu
reviewed
Jan 13, 2022
| "p-queue": "^3.0.0", | ||
| "say": "^0.15.0", | ||
| "p-queue": "^6.6.2", | ||
| "say": "MatchaChoco010/say.js#make-3rd-party-voice-available", |
There was a problem hiding this comment.
I recommend to publish it as package.
Git's Branch is not immutable.
Scoped package is useful for fork repository.
There was a problem hiding this comment.
Ok, I will publish this fork repository as scoped package.
| @@ -160,3 +163,6 @@ export function activate(context: vscode.ExtensionContext) { | |||
| }) | |||
| ); | |||
| } | |||
|
|
|||
| function Hoge() {} | |||
There was a problem hiding this comment.
Oh, sorry. This is debug code. I will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written two patches for say.js.
One is to deal with garbled text in Windows environments. Marak/say.js#121
The other is to support 3rd party readout software. Marak/say.js#124
This PR contains the patches and fixes compilation errors due to environment upgrades.
Since the patches have not yet been imported into the main repository, I am using the forked repository directly.