Skip to content

Show white filled check mark icon #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2025
Merged

Show white filled check mark icon #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3ba068
Show white filled check mark icon
Oct 13, 2025
300da00
Bump package
Oct 13, 2025
0a5aa07
Fix
Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions components/Icons.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,13 @@ function AiAssist (props) {
return <Icon path={path} {...props} />
}

function Check (props) {
const path = 'M8 0C3.6 0 0 3.6 0 8s3.6 8 8 8 8-3.6 8-8-3.6-8-8-8zM7 11.4L3.6 8 5 6.6l2 2 4-4L12.4 6 7 11.4z'
return <Icon path={path} {...props} />
function Check ({ color, className, path, viewBox, width, height, style, checkColor }) {
Copy link
Member

@glebovsky glebovsky Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest setting some defaults here like width, height and viewBox

Copy link
Contributor Author

@adbharadwaj adbharadwaj Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wont do it in this case because we do not set defaults for them in case of other icons.

return (
<svg className={className} width={width} height={height} viewBox={viewBox} style={style} xmlns="http://www.w3.org/2000/svg">
<path d="M8 0C3.6 0 0 3.6 0 8s3.6 8 8 8 8-3.6 8-8-3.6-8-8-8z" fill={color} />
<path d="M7 11.4L3.6 8 5 6.6l2 2 4-4L12.4 6 7 11.4z" fill={checkColor || 'transparent'} />
Copy link
Contributor Author

@adbharadwaj adbharadwaj Oct 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allows me to control the color of the checkmark separately from fill color and background color.

</svg>
)
}

function Checkmark (props) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@b12/metronome",
"version": "1.1.31",
"version": "1.1.32",
"description": "",
"main": "index.es6.js",
"scripts": {
Expand Down
Loading