Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: ObsoleteAttribute for soon to be removed API #1062

Closed
wants to merge 2 commits into from
Closed

add: ObsoleteAttribute for soon to be removed API #1062

wants to merge 2 commits into from

Conversation

linkdotnet
Copy link
Collaborator

Fixes #962

Basically I added some ObsoleteAttribute to the diff API that isn't around in v2 anymore.

@linkdotnet linkdotnet requested a review from egil May 7, 2023 11:58
egil
egil reviewed May 7, 2023
View reviewed changes
Copy link
Member

@egil egil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right use of obsolete. My understanding is that you add obsolete attributes to things that have an alternative available. That wont be the case in v1, so these does not make sense.

@linkdotnet
Copy link
Collaborator Author

I don't think this is the right use of obsolete. My understanding is that you add obsolete attributes to things that have an alternative available. That wont be the case in v1, so these does not make sense.

Fair points - maybe a good documentation is also good enough. We can close that for now.

@linkdotnet linkdotnet closed this May 7, 2023
@linkdotnet linkdotnet deleted the feature/obsolete-diff-api branch May 20, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egil egil egil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V2
2 participants
@linkdotnet @egil