-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/crashloop #100
Open
konst-sauce
wants to merge
17
commits into
master
Choose a base branch
from
feature/crashloop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/crashloop #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved shared instance of BCLD
Added removing of crash report when safe mode detected to prevent entering into crash loop detection loop. Made bad events calculation reverse - from newest event back to closest successful.
vlussenburg
reviewed
Oct 3, 2022
konraddysput
approved these changes
Oct 14, 2022
Added Crash Loop Counter - which counts crash loop events directly in the PLCrashReporter's signals handler. Updated Crash Loop Detector to work with Crash Loop Counter. Updated files structure. Polished comments and code.
…se CLD functionality
@konraddysput - please review latest commit - d0d63d6 |
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopCounter.swift
Outdated
Show resolved
Hide resolved
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopCounter.swift
Outdated
Show resolved
Hide resolved
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopCounter.swift
Outdated
Show resolved
Hide resolved
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopCounter.swift
Outdated
Show resolved
Hide resolved
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopDetector.swift
Outdated
Show resolved
Hide resolved
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopDetector.swift
Show resolved
Hide resolved
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopDetector.swift
Outdated
Show resolved
Hide resolved
Sources/Public/Internal/CrashLoopDetector/BacktraceCrashLoopDetector.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the current version of a Crash Loop Detector.
This request doesn't include a separate file fix to work with Unity+Cocoa environment.