Skip to content

fix [polymart] badges #11073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

fix [polymart] badges #11073

merged 2 commits into from
Jun 20, 2025

Conversation

chris48s
Copy link
Member

All polymart badges were failing with a validation error due to some upstream changes.

This PR fixes

@chris48s chris48s added bug Bugs in badges and the frontend service-badge New or updated service badge labels May 11, 2025
@@ -4,8 +4,7 @@ import { BaseJsonService } from '../index.js'
const resourceSchema = Joi.object({
response: Joi.object({
resource: Joi.object({
price: Joi.number().required(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any badges using the price so this can be removed

Copy link
Contributor

github-actions bot commented May 11, 2025

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against 3fdb471

@chris48s chris48s requested a review from jNullj June 16, 2025 17:59
Copy link
Contributor

🚀 Updated review app: https://pr-11073-badges-shields.fly.dev

Copy link
Member

@jNullj jNullj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Looked at polymart docs and it appears price still exist, but I also see the issue.
As we don't use price, removing it seems like the solution here.

@chris48s chris48s added this pull request to the merge queue Jun 20, 2025
Merged via the queue into badges:master with commit df421da Jun 20, 2025
18 checks passed
@chris48s chris48s deleted the fix-polymart20250511 branch June 20, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend service-badge New or updated service badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants