Merged
Conversation
chris48s
added
bug
chris48s
commented
May 11, 2025
| const resourceSchema = Joi.object({ | ||
| response: Joi.object({ | ||
| resource: Joi.object({ | ||
| price: Joi.number().required(), |
Member
Author
There was a problem hiding this comment.
We don't have any badges using the price so this can be removed
Contributor
Contributor
|
🚀 Updated review app: https://pr-11073-badges-shields.fly.dev |
jNullj
approved these changes
Jun 20, 2025
Member
jNullj
left a comment
jNullj
left a comment
There was a problem hiding this comment.
Looks good.
Looked at polymart docs and it appears price still exist, but I also see the issue.
As we don't use price, removing it seems like the solution here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All polymart badges were failing with a validation error due to some upstream changes.
This PR fixes