Upgrade split #253
Open
Upgrade split #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| << StatusCodeToString(m_status) << ", m_start_key " | ||
| << m_start_key << ", m_end_key " << m_end_key | ||
| << ", key_start " << key_start << ", key_end " << key_end; | ||
|
|
added 2 commits
August 26, 2015 16:06
| @@ -134,6 +134,11 @@ bool TabletIO::Load(const TableSchema& schema, | |||
| StatusCode* status) { | |||
| { | |||
| MutexLock lock(&m_mutex); | |||
| LOG(INFO) << __func__ << ", path " << path << ", status " | |||
| kUnLoading = kTabletUnLoading, | ||
| kUnLoading2 = kTabletUnLoading2 | ||
| kUnLoading2 = kTabletUnLoading2, | ||
| kFrozen = kTabletFrozen, |
There was a problem hiding this comment.
kUnLoading2 kFrozen能加个注释不，分别代表什么状态
There was a problem hiding this comment.
kunloading2是原代码的状态，tablietio进行该卸载第二阶段，需要阻塞读写；kfrozen状态是卸载结束后tabletio进入的状态，表示该区间目前不操作；
| &raw_split_key)) { | ||
| VLOG(5) << "fail to find split key"; | ||
| SetStatusCode(kTableNotSupport, status); | ||
| &raw_split_key)) { |
| @@ -2369,11 +2420,6 @@ void MasterImpl::UnloadTabletCallback(TabletPtr tablet, int32_t retry, | |||
| ProcessOffLineTablet(tablet); | |||
| TryLoadTablet(tablet); | |||
| } else { | |||
There was a problem hiding this comment.
else里面加个CHECK(false)吧。上面CHECK中的onsplit删掉
added 6 commits
September 6, 2015 15:37
|
终于出现ts写坏meta表case了，感觉可以重启这货了 |
|
两年了。。。还能起得来么 |
|
分裂流程的代码结构非常稳定，基本没有更新 |
|
太有毅力了，简直我辈楷模呀，本渣自叹不如！ 话说，感觉master修改meta表要“read-modify-wite”的事务才完全靠谱。。。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify master && tabletserver 's split interface